nixos/proxmox-image: add additionalSpace, bootSize and diskSize options #238735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will test this change tonight. |
illustris
suggested changes
Jun 21, 2023
| @@ -234,6 +253,8 @@ with lib; | |||
| mkdir -p $out/nix-support | |||
| echo "file vma $out/vzdump-qemu-${cfg.filenameSuffix}.vma.zst" >> $out/nix-support/hydra-build-products | |||
| ''; | |||
| bootSize = cfg.qemuConf.bootSize; | |||
| diskSize = cfg.qemuConf.diskSize; | |||
There was a problem hiding this comment.
Suggested change
| diskSize = cfg.qemuConf.diskSize; | |
| inherit (cfg.qemuConf) diskSize bootSize; |
There was a problem hiding this comment.
Sounds great!
Didn't know this would be possible!
What do you think about also adding additionalSpace ?
I just realised I could add this option as well.
There was a problem hiding this comment.
Yep, that would be useful to have too.
There was a problem hiding this comment.
Yep, that would be useful to have too.
- added it as well
- forced pushed the changes with better fitting commit message
- changed name of PR
- tested the
additionalSpaceoption -> worked just fine
MayNiklas
force-pushed
the
proxmox-image-settings
branch
from
41abc6b
to
354fc65
Compare
MayNiklas
force-pushed
the
proxmox-image-settings
branch
from
354fc65
to
d7f89bb
Compare
MayNiklas
changed the title
illustris
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since
make-disk-image.nixhas options to define the size of the EFI partition as well as the size of the whole disk, I think we should also add those options toproxmox-image. This makes it possible, to generate a disk image which already has the wanted size without expanding it afterwards. Since the additional space isn't used, the image size shouldn't increase (compression is being used).nixpkgs/nixos/lib/make-disk-image.nix
Lines 89 to 103 in 030ba16
I used the same defaults as
make-disk-image.nix.In case any additional changes to my PR are wanted - feel free to tell me!
I'm more than happy to discuss the specific implementation.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)