Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CREATE/CREATE2 when account has max nonce #3698

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

marcindsobczak
Copy link
Contributor

Changes:

  • Break execution of CREATE/CREATE2 when account already has max nonce.
    This change is fixing 86 hive consensus tests (out of 99 failing because of CREATE/CREATE2). Constantinople is still failing. I will investigate it next week. Other test (sstoreGas_d0g0v0_Constantinople) is failing only on Constantinople too, so probably problem is in other place than related with this PR.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

It's covered in hive consensus tests

@LukaszRozmej LukaszRozmej merged commit e88a7ee into master Dec 17, 2021
@LukaszRozmej LukaszRozmej deleted the fix/VM_CREATE branch December 17, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants