-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull listeners
block into base classes.
#29
Comments
theengineear
added a commit
that referenced
this issue
May 9, 2019
A new `listeners-mixin` exists which is meant to be more low-level than the `properties-mixin`. It allows us to pull out some code that’s not strictly needed for the `element-mixin`, which mostly wants to concern itself with necessities for creating custom elements. Closes #29
theengineear
added a commit
that referenced
this issue
May 10, 2019
A new `listeners-mixin` exists which is meant to be more low-level than the `properties-mixin`. It allows us to pull out some code that’s not strictly needed for the `element-mixin`, which mostly wants to concern itself with necessities for creating custom elements. Closes #29
theengineear
added a commit
that referenced
this issue
May 10, 2019
A new `listeners-mixin` exists which is meant to be more low-level than the `properties-mixin`. It allows us to pull out some code that’s not strictly needed for the `element-mixin`, which mostly wants to concern itself with necessities for creating custom elements. Closes #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've been playing with the notion of having a static
listeners
block akin to theproperties
block which will handle setup / teardown of listeners on connection / disconnection.There are two important opinions that our
listeners
block has so far made:shadowRoot
.capture
)These simplifications have, thus far, been helpful. However, (1) is important because we may not have a
shadowRoot
in the future, in which case we have to decide if we just fallback to the element itself. It's also important because there are valid use-cases for listening on the host element, not the shadowRoot. For now, you'll just need to manually hook up these listeners usinglisten
andunlisten
.Point (2) seems to be another edge case. Again, if you want to add additional args, the
listen
andunlisten
methods provide for that.The text was updated successfully, but these errors were encountered: