Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Cast a null MediaRange reference to a null string #2889

Merged
merged 1 commit into from
May 6, 2018
Merged

Cast a null MediaRange reference to a null string #2889

merged 1 commit into from
May 6, 2018

Conversation

bespokebob
Copy link
Contributor

@bespokebob bespokebob commented Apr 27, 2018 •
edited by thecodejunkie
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the Nancy code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

When trying to compare a null MediaRange to a string, the implicit cast to string was throwing a NullReferenceException. Fix the operator so that a null MediaRange is cast to a null string.

Resolves #2769

@bespokebob
Cast a null MediaRange reference to a null string
77caaf8 
When trying to compare a null MediaRange to a string, the implicit cast to string was throwing a NullReferenceException. Fix the operator so that a null MediaRange is cast to a null string.
@dnfclas
Copy link

dnfclas commented Apr 27, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@bespokebob bespokebob mentioned this pull request Apr 27, 2018
Closed
7 tasks
@thecodejunkie thecodejunkie merged commit 93c1594 into NancyFx:master May 6, 2018
@bespokebob bespokebob deleted the fix-media-range-null-case branch May 7, 2018 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thecodejunkie thecodejunkie thecodejunkie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bespokebob @dnfclas @thecodejunkie