This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Enable CSRF cookie to has secure flag enabled #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the csrf cookies secure flag. Resolves #2649
src/Nancy/Security/Csrf.cs
Outdated
| @@ -26,7 +26,8 @@ public static class Csrf | |||
| /// <remarks>This is disabled by default.</remarks> | |||
| /// <param name="pipelines">The application pipelines.</param> | |||
| /// <param name="cryptographyConfiguration">The cryptography configuration. This is <see langword="null" /> by default.</param> | |||
| public static void Enable(IPipelines pipelines, CryptographyConfiguration cryptographyConfiguration = null) | |||
| /// <param name="csrfCookieSecureFlag">Set the CSRF cookie secure flag. This is <see langword="false"/> by default</param> | |||
There was a problem hiding this comment.
I think this would be better named as just useSecureCookie
src/Nancy/Security/Csrf.cs
Outdated
| @@ -64,7 +65,7 @@ public static void Enable(IPipelines pipelines, CryptographyConfiguration crypto | |||
| var tokenString = GenerateTokenString(cryptographyConfiguration); | |||
|
|
|||
| context.Items[CsrfToken.DEFAULT_CSRF_KEY] = tokenString; | |||
| context.Response.Cookies.Add(new NancyCookie(CsrfToken.DEFAULT_CSRF_KEY, tokenString, true)); | |||
| context.Response.Cookies.Add(new NancyCookie(CsrfToken.DEFAULT_CSRF_KEY, tokenString, httpOnly: true, secure: csrfCookieSecureFlag)); | |||
There was a problem hiding this comment.
We don't really use named parameters anywhere else in this section of the code
There was a problem hiding this comment.
I'm a whore for clarity true, true requires intellisense
There was a problem hiding this comment.
I wouldn't be true, true, it would be true, useSecureCookie
There was a problem hiding this comment.
true; but true still just means true 😉
Entirely up to you; your code base, I just occasionally have to touch it.
There was a problem hiding this comment.
Both of those changes are in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds optional bool to signature of Csrf.Enable(this.pipelines) to set the csrf cookies secure flag.
I've set it to false by default to avoid unintended activation.
Resolves #2649