This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Upgrade tests to use FakeItEasy 3.3.2 #2742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.0.0's non-virtual setup analyzer gives false positive when complex argument constraint used in indexer, and this was throwing warnings in the build (https://ci.appveyor.com/project/NancyFx/nancy/build/2.0.0-ci0001857-qqrrqvtr#L1311).
|
Hi @blairconrad we just pulled in #2720 which put us on the new csproj format. Upgrading FakeItEasy now is just a question of updating these two lines https://github.com/NancyFx/Nancy/blob/master/test/Directory.Build.props#L29-L30 and it will affect all |
|
Oh, that went through. Cool.
I'm happy to resend, but traveling until Monday. If you can wait, I will do
by then. If not, I'm not offended if you just close this PR and fix on your
own.
…On Jun 2, 2017 09:21, "Andreas Håkansson" ***@***.***> wrote:
Hi @blairconrad <https://github.com/blairconrad> we just pulled in #2720
<#2720> which put us on the new
csproj format. Upgrading FakeItEasy now is just a question of updating
these two lines https://github.com/NancyFx/Nancy/blob/master/test/
Directory.Build.props#L29-L30 and it will affect all *.Tests projects.
Care to send a new PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2742 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADH8FaWk3q9-G2rGgdgP0FqvE19Sn8Dkks5r__47gaJpZM4NRxlY>
.
|
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
3.0.0's non-virtual setup analyzer gives a false positive when complex
argument constraint used in indexer, and this was throwing warnings
in the build
(https://ci.appveyor.com/project/NancyFx/nancy/build/2.0.0-ci0001857-qqrrqvtr#L1311).