DefaultFileSystemReader: if directory does not exist, return empty list of file names.

[damianh]

DefaultFileSystemReader: if directory does not exist, return empty list of file names. This fixes a cryptic TinyIoC exception that is thrown if the root path provider points to a path, or calculates a path that does not exist.

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following the Nancy code style guidelines
• I have provided test coverage for my change (where applicable)

Description

If the path does not exist (root path provider), it will result on a TinyIoC activation exception and not a useful one at that.

This prevents that exception from being thrown. The user will be subsequently get a different but more user friendly error later:

System.Exception: System.Exception : ConfigurableBootstrapper Exception
---- Nancy.RequestExecutionException : Oh noes!
-------- Nancy.ViewEngines.ViewNotFoundException : Unable to locate view 'doublequotedpartial'
Currently available view engine extensions: sshtml,html,htm
...

[damianh]

Do not merge, change will be re-targeted at master and will NOT be back ported to 1.x as it is a corner case.

[thecodejunkie]

👀

[thecodejunkie]

@damianh mate 😄

[damianh]

🕺 The big port and release week is upon us 🕺

[thecodejunkie]

@damianh how about now? 😀