Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Interop to Truffle Libraries #1

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

lukasstadler
Copy link
Contributor

These changes mainly update the interop code in grCUDA (in DeviceArray, etc.) to the new interop API in Truffle.
Additionally, there's some other minor updates:

  • Modify the makefile that runs the parser generator to generate only the necessary files (no listeners, etc.) and to pre-process all files at once (fixes build problems).
  • Don't store the context in the language, and use @CachedContext(GrCUDALanguage.class) in the right places.

Copy link
Contributor

@muellren muellren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one bug in DeviceArrayFunction. There is a new DeviceArrayTest Unit test I plan to merge soon.

Copy link
Contributor

@muellren muellren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes look good to me. The polyglot language tests are passing as well.
Go ahead, you should be able to merge the PR if this is setup correctly.

@lukasstadler lukasstadler merged commit 9e81736 into NVIDIA:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants