feat(indexer): index tx_affected_objects #19447
Merged
+70
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Similar to #19355, introduce `tx_affected_objects` table -- a combination of `tx_input_objects` and `tx_changed_objects` which will both eventually be removed in favour of the new table. ## Test plan ``` sui$ cargo build -p sui-indexer ``` Tests based on reading this field will be included with the PR introducing changes to GraphQL.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
There was a choice with this PR to incorporate received objects in We may want to add a separate index for objects-to-be-received by a transaction, later (that's tracked in a separate issue already). |
bmwill
approved these changes
Sep 19, 2024
Comment on lines
+30
to
+31
| pub affected: Vec<u8>, | ||
| pub sender: Vec<u8>, |
There was a problem hiding this comment.
At some point we should look into how to avoid needing to allocate for these...not a comment on this PR though
amnn
added a commit
that referenced
this pull request
Sep 19, 2024
## Description Prune `tx_affected_objects` (added in #19447) along with other transaction index tables. ## Test plan TBD.
amnn
added a commit
that referenced
this pull request
Sep 19, 2024
## Description Prune `tx_affected_objects` (added in #19447) along with other transaction index tables. ## Test plan TBD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #19355, introduce
tx_affected_objectstable -- a combination oftx_input_objectsandtx_changed_objectswhich will both eventually be removed in favour of the new table.Test plan
Tests based on reading this field will be included with the PR introducing changes to GraphQL.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.