Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MAX_PROTOCOL_VERSION to 59 #19404

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Sep 16, 2024

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: Enable probing of consensus rounds against peers.
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:56pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 9:56pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 9:56pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 9:56pm

@ebmifa
Copy link
Contributor

ebmifa commented Sep 16, 2024

Don't we usually re-generate snapshots for version bumps? Or only the version bump that was missed here?

@mwtian
Copy link
Member Author

mwtian commented Sep 16, 2024

Don't we usually re-generate snapshots for version bumps? Or only the version bump that was missed here?

The snapshots were included with the original cherrypick. We mostly missed the version bump, and a few fixes to the snapshots.

@mwtian mwtian enabled auto-merge (rebase) September 16, 2024 21:55
@mwtian mwtian merged commit c8b7f98 into releases/sui-v1.33.0-release Sep 16, 2024
47 of 49 checks passed
@mwtian mwtian deleted the 1.33-pick branch September 16, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants