feat(graphql): Filter by affected address #19365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
amnn
force-pushed
the
amnn/tx-affected-gql
branch
from
55b08ab
to
5f05c8c
Compare
wlmyng
reviewed
Sep 13, 2024
Comment on lines
105
to
106
| /// If we don't query a lookup table that has a denormalized sender column, we need to | ||
| /// explicitly sp | ||
| /// explicitly specify the sender. |
There was a problem hiding this comment.
even though this was my comment, it took me some time to wrap my head around this. I recall now that explicit_sender is called when constructing the subqueries to determine whether to explicitly add a subquery against tx_senders
No, it does not -- |
amnn
force-pushed
the
amnn/tx-affected-gql
branch
from
5f05c8c
to
6dafa0a
Compare
wlmyng
approved these changes
Sep 16, 2024
amnn
force-pushed
the
amnn/tx-affected-gql
branch
from
6dafa0a
to
116e085
Compare
amnn
changed the base branch from
amnn/tx-affected-ci
to
amnn/txn-test-sponsor
amnn
force-pushed
the
amnn/txn-test-sponsor
branch
2 times, most recently
from
ee46926
to
fd5b1a3
Compare
8 tasks
## Description Add `TransactionBlockFilter.affectedAddress` as a way to filter transactions by their relationship to an address without worrying about what kind of relationship that is. ## Test plan TBD
amnn
force-pushed
the
amnn/tx-affected-gql
branch
from
116e085
to
ddc4099
Compare
amnn
commented
Sep 17, 2024
There was a problem hiding this comment.
@lxfind -- the first staging test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
TransactionBlockFilter.affectedAddressas a way to filter transactions by their relationship to an address without worrying about what kind of relationship that is.Test plan
New E2E tests:
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.