Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop loading unsupported attributes into ManifestEntry #103

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

Niicck
Copy link
Collaborator

@Niicck Niicck commented Nov 18, 2023

fixes #100

django-vite v3's ManifestEntry is now a NamedTuple instead of a dict. So if there were any attributes in a manifest.json entry that were not explicitly named in ManifestEntry, it would throw an error.

  • Fixes: adds isDynamicEntry and dynamicImports to ManifestEntry.
  • Changed: also filters the data we insert into ManifestEntry so that only supported keys are loaded in, to prevent this from happening in the future.

@Niicck Niicck changed the title stop loading unsupported attributes into ManifestEntry fix: stop loading unsupported attributes into ManifestEntry Nov 18, 2023
@janbaykara
Copy link

This is really helpful, would be great if it could be merged in!

@Niicck
Copy link
Collaborator Author

Niicck commented Nov 24, 2023

@MrBin99 @thijskramer

I'm open to signing on as a maintainer for this package. If you guys are interested in that possibility and want to talk it over, you can email me at nick@supergood.site

@thijskramer
Copy link
Collaborator

thijskramer commented Nov 25, 2023

@MrBin99 @thijskramer

I'm open to signing on as a maintainer for this package. If you guys are interested in that possibility and want to talk it over, you can email me at nick@supergood.site

It would be great to add you as a maintainer! But I don't have enough permissions to do that, @MrBin99 has to give you maintainer rights.

Besides all that, I'll merge this PR and create a new release!

@thijskramer thijskramer merged commit 259c506 into MrBin99:master Nov 25, 2023
6 checks passed
@janbaykara
Copy link

Thanks both for getting this merged!

Hey @MrBin99 are you still up for onboarding @Niicck to be a maintainer? Would be really good to make sure this project is well-tended :)

@MrBin99
Copy link
Owner

MrBin99 commented Jan 8, 2024

@Niicck @thijskramer

This is done, thank you helping me maintaining this project !

@Niicck
Copy link
Collaborator Author

Niicck commented Jan 10, 2024

You bet. I'm glad to join the team! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read Vite manifest file since 3.0.0
4 participants