chore(subsystems/discord): catch runtime exception and log only message #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed full stracktraces being logged from the subsystem for Discord due to missing sockets or files. These come from runtime exceptions that we don't catch. I think that the respective error message is sufficient (in most cases) to inform that the Discord subsystem could not be loaded. This reduces the log spam during startup.
skaldarnar
added
Size: S
skaldarnar
changed the title
skaldarnar
commented
Aug 26, 2022
subsystems/DiscordRPC/src/main/java/org/terasology/subsystem/discordrpc/DiscordRPCThread.java
Outdated
Show resolved
Hide resolved
jdrueckert
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed full stracktraces being logged from the subsystem for Discord
due to missing sockets or files. These come from runtime exceptions that
we don't catch.
I think that the respective error message is sufficient (in most cases)
to inform that the Discord subsystem could not be loaded. This reduces
the log spam during startup.