Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split chunkMesh to ChunkMeshImpl #4893

Merged
merged 14 commits into from
Nov 8, 2021
Merged

refactor: split chunkMesh to ChunkMeshImpl #4893

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9cd5d21
chore: split chunkMesh to ChunkMeshImpl
pollend Sep 6, 2021
6c14929
Merge branch 'develop' of github.com:MovingBlocks/Terasology into cho…
pollend Sep 9, 2021
c9bfcc5
chore: remove HeadlessChunkMesh
pollend Sep 9, 2021
fac9edf
Merge branch 'develop' into chore/split-ChunkMesh-into-implementation
pollend Sep 11, 2021
7ef239f
Merge branch 'develop' of github.com:MovingBlocks/Terasology into cho…
pollend Sep 19, 2021
5fb697c
Merge branch 'chore/split-ChunkMesh-into-implementation' of github.co…
pollend Sep 19, 2021
63dd02e
chore: up[date javadocs
pollend Sep 19, 2021
09b552a
Merge branch 'develop' into chore/split-ChunkMesh-into-implementation
pollend Oct 3, 2021
76c33a4
Merge branch 'develop' of github.com:MovingBlocks/Terasology into cho…
pollend Oct 6, 2021
f392965
use destroy event to manage cleaning up chunkmesh
pollend Oct 6, 2021
a7c17c9
chore: remove unused class
pollend Oct 23, 2021
5a27b16
chore: remove comment for disposing mesh
pollend Nov 7, 2021
fa34daf
Merge remote-tracking branch 'origin/develop' into chore/split-ChunkM…
keturn Nov 8, 2021
f74c606
chore: lint 🚮
keturn Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove comment for disposing mesh
  • Loading branch information
@pollend
pollend committed Nov 7, 2021
commit 5a27b167b6e6e790df67ace057655442370a12c4
1 change: 0 additions & 1 deletion engine/src/main/java/org/terasology/engine/rendering/primitives/ChunkMeshImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public boolean hasVertexElements() {
@Override
public boolean updateMesh() {

// IMPORTANT: A mesh can only be generated once.
if (vertexElements == null || disposed) {
return false;
}
Expand Down