This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
detection of requirejs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If requirejs is detected, it will mock the define method for the time underscore and jquery is registered. Additional to that, the whole file now lives in it's own scope to prevent accidentally pollution of the global namespace.
|
LGTM. Could another maintainer ok this before it goes in? |
|
Hi @mjibson, is the PR ready to merge? |
|
@dixon @SamSaffron could one of you OK this? |
|
Woohoo, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If requirejs is detected, it will mock the define method for the time
underscore and jquery is registered.
Additional to that, the whole file now lives in it's own scope to
prevent accidental pollution of the global namespace.
Issue reference: #11