bulletproofs+: some minor cleanup from vtnerd's review

MAKAPOB · Apr 5, 2022 · 5acdd0e · 5acdd0e
1 parent 4c94cfe
commit 5acdd0e
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/src/ringct/bulletproofs_plus.cc b/src/ringct/bulletproofs_plus.cc
@@ -265,7 +265,7 @@ namespace rct
 
         rct::key res = ONE;
         if (n == 1)
-            return res;
+            return x;
 
         n += 1;
         rct::key x1 = copy(x);
@@ -317,16 +317,7 @@ namespace rct
     static rct::key weighted_inner_product(const rct::keyV &a, const epee::span<const rct::key> &b, const rct::key &y)
     {
         CHECK_AND_ASSERT_THROW_MES(a.size() == b.size(), "Incompatible sizes of a and b");
-        rct::key res = rct::zero();
-        rct::key y_power = ONE;
-        rct::key temp;
-        for (size_t i = 0; i < a.size(); ++i)
-        {
-            sc_mul(temp.bytes, a[i].bytes, b[i].bytes);
-            sc_mul(y_power.bytes, y_power.bytes, y.bytes);
-            sc_muladd(res.bytes, temp.bytes, y_power.bytes, res.bytes);
-        }
-        return res;
+        return weighted_inner_product(epee::to_span(a), b, y);
     }
 
     // Fold inner-product point vectors