Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix statedb to differentiate empty value and delete #126

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Aug 1, 2023

What was the problem?

This PR resolves #125

How was it solved?

Update to separate empty value and deleted value

How was it tested?

Updated unit tests in rust and added functional tests in JS

@shuse2 shuse2 requested review from ricott1 and hrmhatef August 1, 2023 20:32
@shuse2 shuse2 self-assigned this Aug 1, 2023
src/diff.rs Outdated Show resolved Hide resolved
src/diff.rs Outdated Show resolved Hide resolved
src/state/state_writer.rs Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from hrmhatef August 2, 2023 07:39
src/diff.rs Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from ricott1 August 2, 2023 10:30
@shuse2 shuse2 enabled auto-merge (squash) August 2, 2023 16:31
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Commit SHA:ca557b33cdce3091c53053f30154621cb78e9dd4

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 125-fix-empty-value 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 87.42 (0.29) 69.93 (0.7) 94.23 (0) 87.2 (0.3)
🟢 state_db.js 90.47 (0.68) 72.05 (1.47) 98.5 (0) 90.34 (0.69)

@shuse2 shuse2 merged commit b112cb3 into main Aug 3, 2023
8 checks passed
@shuse2 shuse2 deleted the 125-fix-empty-value branch August 3, 2023 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow storing empty key in SMT
3 participants