Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix proof verification for zero append bitmap #100

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Fix proof verification for zero append bitmap #100

merged 7 commits into from
Mar 10, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Mar 3, 2023

What was the problem?

This PR resolves #99

How was it solved?

  • Add check on verify_query_keys

How was it tested?

  • Added unit test to verify zero byte append and prepend bitmap proof

@shuse2 shuse2 self-assigned this Mar 3, 2023
@shuse2 shuse2 requested a review from hrmhatef March 3, 2023 10:41
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Commit SHA:b2b8980c3d75a2c7f18e58614d211fe77a7bf03b
No changes to code coverage between the base branch and the head branch

@shuse2 shuse2 force-pushed the 99-fix-bitmap-verification branch from 7deb6fc to 891b465 Compare March 3, 2023 15:53
@shuse2 shuse2 mentioned this pull request Mar 3, 2023
Closed
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Commit SHA:c73dbd49c53dbff47cc322b059fc9fff1ff9326c
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Commit SHA:dfd6967ac8aba2a47b1f1eeb7c5ef2690bdeb731
No changes to code coverage between the base branch and the head branch

hrmhatef
hrmhatef approved these changes Mar 4, 2023
View reviewed changes
Copy link
Contributor

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.👍

@shuse2 shuse2 requested a review from ricott1 March 6, 2023 16:26
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Commit SHA:6af0466cfee672a54eb0717788b4fbafdde099de
No changes to code coverage between the base branch and the head branch

@shuse2 shuse2 enabled auto-merge (squash) March 10, 2023 10:49
@shuse2 shuse2 merged commit 308d18c into main Mar 10, 2023
@shuse2 shuse2 deleted the 99-fix-bitmap-verification branch March 10, 2023 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matjazv matjazv matjazv approved these changes

@ricott1 ricott1 ricott1 approved these changes

@hrmhatef hrmhatef hrmhatef approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zero byte at the beginning or the end of proof bitmap should be invalid
4 participants
@shuse2 @matjazv @ricott1 @hrmhatef