Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/LIVE-5045 Improve access to debug screens #2225

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Conversation

juan-cortes
Copy link
Contributor

📝 Description

Right now, navigating away and coming back resets the access to the menu, meaning our dear QA need to do the click click click dance over and over again. By moving that into the app runtime state we can keep it open for the duration of the application run.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-5045

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

No demo

🚀 Expectations to reach

Accessing the menu should be remembered as long as the app is running, a new launch should reset the visibility.
Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: 7299aa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Dec 29, 2022 at 7:13PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 29, 2022 at 7:13PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Dec 29, 2022 at 7:13PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Dec 29, 2022 at 7:13PM (UTC)

@github-actions github-actions bot added the mobile Has changes in LLM label Dec 29, 2022
Copy link
Contributor

@alexandremgo alexandremgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏋️‍♀️

@alexandremgo alexandremgo merged commit a30a259 into develop Dec 30, 2022
@alexandremgo alexandremgo deleted the feat/LIVE-5045 branch December 30, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants