Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error msg when trying to write leaf to root of hdf5 file #1247

Merged
merged 8 commits into from
Feb 4, 2024
Merged

better error msg when trying to write leaf to root of hdf5 file #1247

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e248ce2
better error msg when trying to write leaf to root of hdf5 file
cyrush Feb 3, 2024
7efde5b
compile
cyrush Feb 3, 2024
d33626a
compile
cyrush Feb 3, 2024
3277bdc
move ci base tests from ub 18 to ub 20 due to vscode chicanery
cyrush Feb 3, 2024
1d8665a
windows clang avoid c++98 compat warnings
cyrush Feb 3, 2024
8eba98d
more testing
cyrush Feb 3, 2024
ae48a4f
clang, those flags are for clang
cyrush Feb 4, 2024
b3b9611
grumble
cyrush Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clang, those flags are for clang
  • Loading branch information
@cyrush
cyrush committed Feb 4, 2024
commit ae48a4f9bd88f8c79a716070ed09cf2dc1846ead
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
cmake -S src -B build `
-DBLT_CXX_STD=c++14 `
-DCMAKE_BUILD_TYPE=Release `
-DCMAKE_CXX_FLAGS="-Wno-c++98-compat" `
-DENABLE_PYTHON=ON `
-DENABLE_MPI=ON
cmake --build build --config Release --parallel 2
Expand Down Expand Up @@ -116,6 +115,7 @@ jobs:
-G "Ninja" ^
-DCMAKE_C_COMPILER=clang-cl ^
-DCMAKE_CXX_COMPILER=clang-cl ^
-DCMAKE_CXX_FLAGS="-Wno-c++98-compat" ^
-DCMAKE_BUILD_TYPE=Debug
cmake --build build --config Debug --parallel 2
cmake -E env CTEST_OUTPUT_ON_FAILURE=1 cmake --build build --config Debug --target test --parallel 1
Expand Down
Loading