The Cyclomatic Complexity of this method "create" is 18 which is grea…

…ter than 10 authorized.
KwokJay · May 21, 2021 · 3cf86f8 · 3cf86f8
1 parent 3a99066
commit 3cf86f8
Showing 1 changed file with 26 additions and 19 deletions.
diff --git a/library/src/main/java/com/github/gzuliyujiang/oaid/impl/OAIDFactory.java b/library/src/main/java/com/github/gzuliyujiang/oaid/impl/OAIDFactory.java
@@ -43,25 +43,8 @@ public static IOAID create(@NonNull Context context) {
         if (ioaid != null) {
             return ioaid;
         }
-        if (OAIDRom.isLenovo() || OAIDRom.isMotolora()) {
-            ioaid = new LenovoImpl(context);
-        } else if (OAIDRom.isMeizu()) {
-            ioaid = new MeizuImpl(context);
-        } else if (OAIDRom.isNubia()) {
-            ioaid = new NubiaImpl(context);
-        } else if (OAIDRom.isXiaomi() || OAIDRom.isMiui() || OAIDRom.isBlackShark()) {
-            ioaid = new XiaomiImpl(context);
-        } else if (OAIDRom.isSamsung()) {
-            ioaid = new SamsungImpl(context);
-        } else if (OAIDRom.isVivo()) {
-            ioaid = new VivoImpl(context);
-        } else if (OAIDRom.isASUS()) {
-            ioaid = new AsusImpl(context);
-        } else if (OAIDRom.isHuawei() || OAIDRom.isEmui()) {
-            ioaid = new HuaweiImpl(context);
-        } else if (OAIDRom.isOppo() || OAIDRom.isOnePlus()) {
-            ioaid = new OppoImpl(context);
-        }
+        // 优先尝试各厂商自家提供的接口
+        ioaid = createManufacturerImpl(context);
         if (ioaid != null && ioaid.supported()) {
             OAIDLog.print("Manufacturer interface has been found: " + ioaid.getClass().getName());
             return ioaid;
@@ -84,4 +67,28 @@ public static IOAID create(@NonNull Context context) {
         return ioaid;
     }
 
+    private static IOAID createManufacturerImpl(Context context) {
+        IOAID ioaid = null;
+        if (OAIDRom.isLenovo() || OAIDRom.isMotolora()) {
+            ioaid = new LenovoImpl(context);
+        } else if (OAIDRom.isMeizu()) {
+            ioaid = new MeizuImpl(context);
+        } else if (OAIDRom.isNubia()) {
+            ioaid = new NubiaImpl(context);
+        } else if (OAIDRom.isXiaomi() || OAIDRom.isMiui() || OAIDRom.isBlackShark()) {
+            ioaid = new XiaomiImpl(context);
+        } else if (OAIDRom.isSamsung()) {
+            ioaid = new SamsungImpl(context);
+        } else if (OAIDRom.isVivo()) {
+            ioaid = new VivoImpl(context);
+        } else if (OAIDRom.isASUS()) {
+            ioaid = new AsusImpl(context);
+        } else if (OAIDRom.isHuawei() || OAIDRom.isEmui()) {
+            ioaid = new HuaweiImpl(context);
+        } else if (OAIDRom.isOppo() || OAIDRom.isOnePlus()) {
+            ioaid = new OppoImpl(context);
+        }
+        return ioaid;
+    }
+
 }