Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put时使用CONFUSE(address)作为key，Erase也应使用CONFUSE(address)作为key #240

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Put时使用CONFUSE(address)作为key，Erase也应使用CONFUSE(address)作为key #240

merged 2 commits into from
Apr 12, 2023

Conversation

Mr-JingShi
Copy link
Contributor

No description provided.

@alhah alhah requested a review from lbtrace April 11, 2023 12:06
@lbtrace lbtrace added the bug Something isn't working label Apr 12, 2023
@lbtrace
Copy link
Contributor

lbtrace commented Apr 12, 2023

@Mr-JingShi 感谢 PR，这里 koom-native-leak/src/main/jni/src/leak_monitor.cpp # 208 行也需要调整：
UnregisterAlloc(live->address); =》UnregisterAlloc(CONFUSE(live->address)); 因为 live->address 本身是取反后的地址；你在这个 PR 上再改下，我帮你 Merge

@lbtrace
Copy link
Contributor

lbtrace commented Apr 12, 2023

LGTM

@lbtrace lbtrace merged commit e359ec1 into KwaiAppTeam:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbtrace lbtrace Awaiting requested review from lbtrace

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr-JingShi @lbtrace