Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docs and guide on flow cancellation #2043

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Conversation

elizarov
Copy link
Contributor

  • Remove outdated phrase on "flow infrastructure does not introduce additional cancellation points". They were introduced by Flow cancellation #2028
  • Add a section on "Flow cancellation check" with examples on `Flow.cancellable()`` operator.
  • Add a bit more detail in flow and cancellable docs with links to ensureActive().

* Remove outdated phrase on "flow infrastructure does not introduce additional cancellation points". They were introduced by #2028
* Add a section on "Flow cancellation check" with examples on `Flow.cancellable()`` operator.
* Add a bit more detail in `flow` and `cancellable` docs with links to `ensureActive()`.
@elizarov elizarov requested a review from qwwdfsad May 21, 2020 09:54
docs/flow.md Outdated Show resolved Hide resolved
docs/flow.md Outdated Show resolved Hide resolved
docs/flow.md Show resolved Hide resolved
@elizarov elizarov merged commit 9bbb669 into develop Jun 3, 2020
@elizarov elizarov deleted the flow-cancel-docs branch June 3, 2020 09:02
@elizarov elizarov mentioned this pull request Jul 16, 2020
1 task
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
* Improve the docs and guide on flow cancellation
* Remove outdated phrase on "flow infrastructure does not introduce additional cancellation points". They were introduced by Kotlin#2028
* Add a section on "Flow cancellation check" with examples on `Flow.cancellable()`` operator.
* Add a bit more detail in `flow` and `cancellable` docs with links to `ensureActive()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants