fix preprocessor guards for getContextPlatformVersion #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to file an issue (or add a test) to ensure these types of failures are caught in the future. |
|
I've added a test to ensure these issues will be caught in the future - see #252. These tests fail currenlty, but will pass once this PR is merged. |
Kerilk
approved these changes
Dec 5, 2023
|
Merging as discussed in the December 5th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108
This change corrects the preprocessor guards around detail functions to get the OpenCL version from a platform, device, or context.
CL_HPP_TARGET_OPENCL_VERSIONneeds to be the smallest value that callers of these functions test for. This is correctly120for current usages of these functions.CL_HPP_MINIMUM_OPENCL_VERSIONneeds to be the largest value that callers of these functions test for. This needs to be200, for example for command queue properties.Debatably the preprocessor guards around these functions should be removed completely, but at least this way things won't be broken while we figure out if this is the right thing to do or not.