Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for svm allocator #226

Merged
merged 1 commit into from
May 30, 2023
Merged

test for svm allocator #226

merged 1 commit into from
May 30, 2023

Conversation

pwisniewskimobica
Copy link
Contributor

I wrote some code to test allocate and deallocate API (clSVMAlloc, clSVMFree, clEnqueueSVMMap)

@pwisniewskimobica pwisniewskimobica force-pushed the test_svm_allocation branch 3 times, most recently from 79f4cd2 to eb1d981 Compare April 24, 2023 13:11
bashbaug
bashbaug reviewed May 2, 2023
View reviewed changes
tests/test_openclhpp.cpp Show resolved Hide resolved
tests/test_openclhpp.cpp Show resolved Hide resolved
tests/test_openclhpp.cpp Show resolved Hide resolved
tests/test_openclhpp.cpp Show resolved Hide resolved
@pwisniewskimobica pwisniewskimobica force-pushed the test_svm_allocation branch 3 times, most recently from 74d0a25 to e847377 Compare May 8, 2023 15:37
bashbaug
bashbaug reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one last comment. Also needs a rebase (hopefully trivial).

tests/test_openclhpp.cpp Show resolved Hide resolved
bashbaug
bashbaug approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for CI to complete (which has been a problem recently...).

@pwisniewskimobica
Copy link
Contributor Author

@bashbaug CI failed because of random stuff- some CI internal errors probably.
Rebased and pushed again to see if CI works

@bashbaug
Copy link
Contributor

Merging as discussed in the May 30th teleconference.

@bashbaug bashbaug merged commit 5ec264a into KhronosGroup:main May 30, 2023
@bashbaug bashbaug mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwisniewskimobica @bashbaug