Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several classes of warnings that are creating a lot of noise in the build. Those may be hiding issues we would like to fix. I will rebase on #218 as I didn't want to muddy the waters by adding those commit to the existing PR. The classes of issues fixed are:
(void)
;cl_uint
used as loop bounds to(int)
to compare against the loop counter;;
when unneeded after macros;Once this and #218 are merged, remaining warnings need to be investigated, and we may think about activating
-Werror
at least on Linux and MacOS targets.