Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #221

Merged
merged 7 commits into from
Apr 9, 2023
Merged

Fix warnings #221

merged 7 commits into from
Apr 9, 2023

Conversation

Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Apr 7, 2023

This fixes several classes of warnings that are creating a lot of noise in the build. Those may be hiding issues we would like to fix. I will rebase on #218 as I didn't want to muddy the waters by adding those commit to the existing PR. The classes of issues fixed are:

  • Explicitly cast unused arguments to (void);
  • Cast cl_uint used as loop bounds to (int) to compare against the loop counter;
  • Initialize an array to 0;
  • Remove unused variable;
  • Remove extra ; when unneeded after macros;
  • Add guards around static functions so that they are defined only when used.

Once this and #218 are merged, remaining warnings need to be investigated, and we may think about activating -Werror at least on Linux and MacOS targets.

@Kerilk Kerilk requested a review from bashbaug April 7, 2023 22:51
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Still a few more but this is a nice improvement...

@bashbaug bashbaug merged commit d264f6d into KhronosGroup:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants