use tuple args for broadcast #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Jul 15, 2020
300: fix `fill` when length = 0 r=maleadt a=Ellipse0934 As reported in [#81](JuliaGPU/CUDA.jl#81) , CUDA.jl . Currently constructors such as `CUDA.zeros(T, 0)` would fail for the types not handled by CUDA memset (64-bit numbers not supported). Previously ```julia julia> T = Float64 julia> CuArrays.zeros(T, 0) ERROR: AssertionError: total_threads > 0 Stacktrace: [1] #gpu_call#1 at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/GPUArrays/OXvxB/src/device/execution.jl:60 [inlined] [2] gpu_call at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/GPUArrays/OXvxB/src/device/execution.jl:46 [inlined] [3] fill!(::CuArray{Float64,1,Nothing}, ::Int64) at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/GPUArrays/OXvxB/src/host/construction.jl:12 [4] zeros(::Type{T} where T, ::Int64, ::Vararg{Int64,N} where N) at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/CuArrays/l0gXB/src/array.jl:337 [5] top-level scope at REPL[129]:1 ``` Now: ```julia julia> CUDA.zeros(Float64, 0) 0-element CuArray{Float64,1} ``` Co-authored-by: Ellipse0934 <Ellipse0934@github.com>
danielwe
added a commit
to danielwe/GPUArrays.jl
that referenced
this pull request
Nov 29, 2020
Same problem as in JuliaGPU#81, fixed in JuliaGPU#300, but for `repeat`.
danielwe
added a commit
to danielwe/GPUArrays.jl
that referenced
this pull request
Nov 29, 2020
Same problem as in JuliaGPU#81, fixed in JuliaGPU#300, but for `repeat`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix JuliaGPU/CLArrays.jl#5