-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve context switching #761
Conversation
Make sure they infer, and add an option to skip the body if the context has been destroyed.
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 78.26% 78.26% -0.01%
==========================================
Files 122 122
Lines 7280 7269 -11
==========================================
- Hits 5698 5689 -9
+ Misses 1582 1580 -2
Continue to review full report at Codecov.
|
The call to is_pinned generates a 'failure' for every memory copy. Enabling CUTENSOR tests causes some downstream failures in _other_ CUTENSOR tests though, so disable those (pinned memory) tests.
6be62a5
to
72de062
Compare
Thanks for the ping, I would have missed this but the timing is perfect for me to give this another go, will report back 🤞 |
So funnily enough the very first thing I ran with this PR I saw finalizer error, then haven't been able to reproduce in an ~hour of some farily complicated stuff. So maybe there's still an edge case out there, but overall definitely seems like an improvement, thanks! |
I've been seeing some other finalizer errors on CI too, it's always |
Some performance (inferability) fixes, but also some bug fixes where we didn't switch to the appropriate context from finalizers. This would only surface in a multi-device setting (cc @marius311, in case you're still trying to do multi-device work in a single process).