Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry library initialization failure due to (badly reported) OOM. #268

Merged
merged 1 commit into from
Jul 4, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jul 2, 2020

Fixes #264

@maleadt maleadt added enhancement New feature or request cuda libraries Stuff about CUDA library wrappers. labels Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #268 into master will decrease coverage by 0.07%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   80.40%   80.32%   -0.08%     
==========================================
  Files         155      155              
  Lines       10235    10273      +38     
==========================================
+ Hits         8229     8252      +23     
- Misses       2006     2021      +15     
Impacted Files Coverage Δ
lib/cusparse/wrappers.jl 90.88% <75.00%> (+0.37%) ⬆️
lib/cublas/wrappers.jl 91.20% <83.33%> (-0.20%) ⬇️
lib/curand/wrappers.jl 90.00% <83.33%> (-10.00%) ⬇️
lib/cusolver/wrappers.jl 92.97% <83.33%> (+1.48%) ⬆️
lib/cublas/CUBLAS.jl 97.36% <100.00%> (ø)
lib/cudnn/base.jl 92.85% <100.00%> (ø)
lib/curand/random.jl 89.01% <100.00%> (-0.12%) ⬇️
src/memory/split.jl 83.17% <0.00%> (-9.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22921e...5fbbfa4. Read the comment docs.

@maleadt maleadt merged commit 8b8f656 into master Jul 4, 2020
@maleadt maleadt deleted the tb/retry_library_init branch July 4, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library handle creation close to OOM fails with ERROR_NOT_INITIALIZED
1 participant