Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't extend Base.findfirst with an unrelated method. #230

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 18, 2020

No description provided.

@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request labels Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #230 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   81.95%   81.87%   -0.09%     
==========================================
  Files         145      145              
  Lines        9516     9516              
==========================================
- Hits         7799     7791       -8     
- Misses       1717     1725       +8     
Impacted Files Coverage Δ
src/indexing.jl 94.80% <100.00%> (ø)
lib/cuda/occupancy.jl 76.00% <0.00%> (-20.00%) ⬇️
deps/bindeps.jl 83.66% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73893e...5af5245. Read the comment docs.

@maleadt maleadt merged commit 23ad26c into master Jun 19, 2020
@maleadt maleadt deleted the tb/hide_findfirstval branch June 19, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant