Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup database #1

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Setup database #1

merged 4 commits into from
Nov 11, 2020

Conversation

Jorbreezy
Copy link
Owner

No description provided.

joelcolucci
joelcolucci suggested changes Nov 11, 2020
View reviewed changes
Copy link

@joelcolucci joelcolucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Change items

  1. Let's rename this PR so it makes it obvious what the purpose of this PR is.
  2. dotenv should not be a dependency or referenced in our app.
    Checkout the dotenv CLI. That should allow us to load envvars without including in our app.

@Jorbreezy Jorbreezy changed the title Configure dotenv Setup database Nov 11, 2020
joelcolucci
joelcolucci reviewed Nov 11, 2020
View reviewed changes
package.json Outdated
"start": "dotenv node ./bin/www",
"dev": "dotenv DEBUG=* nodemon ./bin/www",
"db:migrate": "dotenv knex migrate:latest",
"db:seeds": "dotenv knex seed:run",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@Jorbreezy Jorbreezy merged commit ac70fbd into main Nov 11, 2020
@Jorbreezy Jorbreezy deleted the db-setup branch November 11, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelcolucci joelcolucci joelcolucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorbreezy @joelcolucci