We need a break!
#83
Merged
We need a break!
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
reviewed
Aug 1, 2019
| } | ||
| case PIN_HASH: { | ||
| if (!ipfsHash) { | ||
| log('PIN_HASH: no ipfsHash given: %O', message.data); | ||
| if (log.enabled) { | ||
| // Only stringify when absolutely necessary |
There was a problem hiding this comment.
Can we add this to the REPLICATE case below and the 'could not parse pinner message' error above?
There was a problem hiding this comment.
Oh, yeah sure, I missed those!
area
reviewed
Aug 1, 2019
src/Pinion.ts
Outdated
| } catch (caughtError) { | ||
| if (log.enabled) { | ||
| // Only stringify when absolutely necessary | ||
| log('Could not parse pinner message: %O', message.data); |
There was a problem hiding this comment.
This doesn't even stringify when absolutely necessary 😛
EDIT: Nor does the REPLICATE one
chmanie
force-pushed
the
fix/catch-a-break
branch
from
b4b6a2c
to
41a6716
Compare
JamesLefrere
approved these changes
Aug 1, 2019
area
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
breakstatement for theANNOUNCE_CLIENTcase to not fall through to thePIN_HASHcase.Also we're sneaking in a commit to improve the buffer logging in debug mode