Fix Warnings & PyLint #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various improvements and fixes across multiple files in the
custom_components/dreodirectory. The changes primarily focus on code quality enhancements, bug fixes, and the addition of new functionalities.Code Quality Improvements:
custom_components/dreo/__init__.py: Added pylint disable comment to the import statement forDreoDeviceType.custom_components/dreo/fan.py: Added pylint disable comment forunused-argumentin theasync_setup_entryfunction.custom_components/dreo/number.py: Added pylint disable comment forabstract-methodin theDreoNumberHAclass.Bug Fixes:
custom_components/dreo/fan.py: Corrected the debug log to uselen(fan_entities_ha)instead offan_entities_ha.count.custom_components/dreo/humidifier.py: Corrected the debug log to usehumidifier_entities_ha.count()instead ofhumidifier_entities_ha.count.New Functionalities:
custom_components/dreo/dreofan.py: Added a new methodset_directionto set the direction of the fan.Refactoring:
custom_components/dreo/pydreo/constant.py: RenamedDREO_DEVICE_SETTINGtoDreoDeviceSettingand updated the constant names to follow a consistent naming convention.custom_components/dreo/pydreo/pydreofanbase.py: Updated references toDREO_DEVICE_SETTING.FanTempOffsettoDreoDeviceSetting.FAN_TEMP_OFFSET. [1] [2]Documentation:
custom_components/dreo/pydreo/pydreoaircirculator.py: Added docstrings for properties related to oscillation angles. [1] [2]