Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 and Ceiling Fan Fixes #175

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Python 3.12 and Ceiling Fan Fixes #175

merged 4 commits into from
Sep 1, 2024

Conversation

JeffSteinbok
Copy link
Owner

Major Changes

  • Python 3.12 Support

This pull request includes several updates to enhance the functionality and compatibility of the Dreo fan integration and its testing framework. The most important changes involve updating the Python version in the CI workflow, expanding fan features, and adding new test cases.

Compatibility and Setup:

  • Updated the Python version in the GitHub Actions workflow from 3.11 to 3.12 in .github/workflows/pytest.yaml to ensure compatibility with the latest Python release.

Feature Enhancements:

  • Expanded the supported features of the fan to include TURN_ON and TURN_OFF in custom_components/dreo/fan.py.
  • Introduced FAN_MODE_STRINGS dictionary to map mode strings to user-friendly names in custom_components/dreo/pydreo/constant.py.
  • Updated the parse_preset_modes method to use FAN_MODE_STRINGS for mode identification in custom_components/dreo/pydreo/pydreofan.py.

Testing Framework:

  • Added new test cases for the HCF005S fan model in tests/pydreo/test_pydreofan.py to verify fan speed and preset modes, and to ensure commands are sent correctly.

Dependency Management:

  • Replaced pytest-homeassistant-custom-component with homeassistant in requirements.test.txt to streamline dependencies.

@JeffSteinbok JeffSteinbok merged commit e2bb3b2 into main Sep 1, 2024
3 checks passed
@JeffSteinbok JeffSteinbok deleted the feature/fix_HCF001S branch September 1, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant