Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaFX to 23 #11757

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Update JavaFX to 23 #11757

merged 4 commits into from
Sep 17, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 13, 2024

https://github.com/openjdk/jfx/blob/master/doc-files/release-notes-23.md

Not on Maven Central yet. Maybe tomorrow?

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@koppor
Copy link
Member Author

koppor commented Sep 14, 2024

Blocked by https://central.sonatype.com/artifact/org.openjfx/javafx/versions not having JavaFX 23

@Siedlerchr
Copy link
Member

Will probably take a couple of more days, official jdk release is scheduled for 17th https://jdk.java.net/23/ so javafx will probably be released at the same time

@Siedlerchr Siedlerchr marked this pull request as ready for review September 17, 2024 06:58
Copy link
Contributor

github-actions bot commented Sep 17, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 213673f Sep 17, 2024
32 of 34 checks passed
@Siedlerchr Siedlerchr deleted the update-javafx branch September 17, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants