Skip to content

Commit

Permalink
Disable the warning that cache is disabled in append mode
Browse files Browse the repository at this point in the history
In append mode we don't necessarily have the flat node setting from the
command line, because it is read from the properties file. So this would
give us an unnecessary and wrong warning.

This is just a band aid though, a better fix would be to check after we
have read the properties file. But that needs some larger changes I'll
leave for when we refactor the command line parsing code.
  • Loading branch information
joto committed Aug 28, 2023
1 parent 368d67d commit 8bb8fca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/command-line-parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ static void check_options(options_t *options)
throw std::runtime_error{
"RAM node cache can only be disabled in slim mode."};
}
if (options->flat_node_file.empty()) {
if (options->flat_node_file.empty() && !options->append) {
log_warn("RAM cache is disabled. This will likely slow down "
"processing a lot.");
}
Expand Down

0 comments on commit 8bb8fca

Please sign in to comment.