Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whisper] Update korean i18n (ko-kr.conf) #1343

Merged
merged 3 commits into from
May 9, 2024

Conversation

HotoRas
Copy link
Contributor

@HotoRas HotoRas commented May 4, 2024

Time has passed from #1037 , and there were some huge changes. However, the i18n for Korean (which I lastly managed) is not updated- quite a lot that the default fallback, Classic Chinese, would appear even the setting is correct as Korean.
So for now, I'm making this PR to update the i18n file to fix that issue.

ko-kr.conf:

  • release-name: Add 毕宿 (Net) and 附耳 (Whisper), untranslated from en-us
  • dfu-disable: Add symlink-file-exist and lightcity-not-installed, untranslated from en-us
  • comments: Remove optimization.disable-data-fixer.comment
  • comments: Add compatibility.valid-username-regex.comment and velocity.*
    • velocity.* is untranslated from en-us

@IzzelAliz
Copy link
Owner

Better not keep English values in korean file. The default fallback should be en_us in recent versions.

@HotoRas
Copy link
Contributor Author

HotoRas commented May 5, 2024

OK, got it and now I'm working some more work localizing extra lines still in English rn.. but it'll take time- like a week or two.

Likely no English-only string remains so far
@HotoRas
Copy link
Contributor Author

HotoRas commented May 5, 2024

OK, got it and now I'm working some more work localizing extra lines still in English rn.. but it'll take time- like a week or two.

Managed to do it in hours

@IzzelAliz IzzelAliz merged commit 1a73f8e into IzzelAliz:Whisper May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants