Jsonld alter caching #747
Merged
Jsonld alter caching #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: Islandora/documentation#1379
What does this Pull Request do?
Fixes tests by changing how we invalidate caching with our jsonld alters... and nudging the tests a little.
What's new?
I add some cache tags to the
$context['cacheability']metadata provided in the alter function.How should this be tested?
Before this PR:
schema:sameAswith the Drupal URL in there.Contentcontext and change the self reference URL toowl:sameAs.owl:sameAs. It's stillschema:sameAs!After this PR:
schema:sameAswith the Drupal URL in there.Contentcontext and change the self reference URL toowl:sameAs.owl:sameAsas expected.Additional Notes:
This unblocks a bunch of PRs because tests are failing.
Interested parties
@Islandora/8-x-committers