feat: Support for ciris #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me but wouldn't it be better to be added to the Ciris repository? For example, this is already the case of Refined support. |
|
That's also possible, however i thought it fitted nice with ciris support. But you're right it might be better suited over there. Let' me check |
|
I'm leaving this PR open in case Ciris maintainers can't or don't want to support Iron in their repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using a generic implicit to use iron with ciris. It works fine for me. I have added a test, which is mostly a smoke test to see that it works. It does however perform a proper summon of a
ciris.ConfigDecoderlet me know what else to do/change.