Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken error handling around Idempotent producer + Ensure strict ordering when Net.MaxOpenRequests = 1 #2943

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix broken error handling around Idempotent producer + Ensure strict ordering when Net.MaxOpenRequests = 1 #2943

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0a07760
sync produce
richardartoul Jul 19, 2024
78b02d0
add sequence for retries
richardartoul Jul 19, 2024
46d19e5
panic if no sequence
richardartoul Jul 19, 2024
e715c7d
maintain producer ID and epoch when retrying batch
richardartoul Jul 19, 2024
d22f96f
panic out of order
richardartoul Jul 19, 2024
337aab2
wip
richardartoul Jul 19, 2024
b7cc6fc
improve and add comments
richardartoul Jul 19, 2024
82e8795
remove unnecessary check
richardartoul Jul 19, 2024
401c990
better comment
richardartoul Jul 19, 2024
2d7cdb6
Add kafkastorageerror as retriable
richardartoul Jul 19, 2024
1cf850b
fix typo
richardartoul Jul 19, 2024
1125d60
improve error logging
richardartoul Jul 20, 2024
b73a5f2
more logging
richardartoul Jul 20, 2024
0222838
dont clear message before logging
richardartoul Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve error logging
  • Loading branch information
@richardartoul
richardartoul committed Jul 20, 2024
commit 1125d60679719cf757d97c50b53441b0a168711b
10 changes: 10 additions & 0 deletions async_producer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,16 @@ func (pe ProducerError) Unwrap() error {
type ProducerErrors []*ProducerError

func (pe ProducerErrors) Error() string {
if len(pe) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this ever actually be produced with zero messages?

If it’s unlikely to ever happen with len(pe) == 0 then that should be the guard condition, and then the complex error message should be the unindented path.

return fmt.Sprintf(
"kafka: Failed to deliver %d messages, sample error: %v after %d retries on topic: %s and partition: %d",
len(pe),
pe[0].Err,
pe[0].Msg.retries,
pe[0].Msg.Topic,
pe[0].Msg.Partition,
)
}
return fmt.Sprintf("kafka: Failed to deliver %d messages.", len(pe))
}

Expand Down