Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-chrome: delete launchctl services only with zap #92704

Merged
merged 1 commit into from
Nov 15, 2020
Merged

google-chrome: delete launchctl services only with zap #92704

merged 1 commit into from
Nov 15, 2020

Conversation

i0ntempest
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask audit --new-cask {{cask_file}} worked successfully.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.

@i0ntempest
Copy link
Contributor Author

i0ntempest commented Nov 14, 2020

Reasons:

  1. Currently only launchctl plists are removed when uninstalling, but the actual executables are kept unless one executes zap. Makes no sense to me.
  2. Google software update service is used by a lot of other google softwares (e.g. multiple versions of Chrome, Google Drive), deleting this service borks automatic update for all installed google softwares. And for this reason, I suggest we do this for all Google softwares in this repo.

@vitorgalvao vitorgalvao merged commit 038df6f into Homebrew:master Nov 15, 2020
@i0ntempest i0ntempest deleted the chrome branch November 15, 2020 01:13
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants