Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump little snitch@5 to 5.8 #186369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

holser
Copy link
Contributor

@holser holser commented Sep 23, 2024

5.8 is compatible with MacOS 15.0 Sequioia

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • [ x ] Named the cask according to the token reference.
  • [ x ] Checked the cask was not already refused (add your cask's name to the end of the search field).
  • [ x ] brew audit --cask --new <cask> worked successfully.
  • [ x ] HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • [ x ] brew uninstall --cask <cask> worked successfully.

5.8 is compatible with MacOS 15.0 Sequioia
@holser
Copy link
Contributor Author

holser commented Sep 24, 2024

CI won't pass as cask checks the version in plist and fails as it gets version mismatch

@p-linnane
Copy link
Member

This release is specific to Sequoia only, which is probably why the plist hasn't been updated to point everyone to it.

@holser
Copy link
Contributor Author

holser commented Sep 24, 2024

I guess we should check https://sw-update.obdev.at/products/littlesnitch/releasenotes-swu-5.html instead of plist. Alternatively I can disable plist verification in Cask

@p-linnane
Copy link
Member

The cask needs to be reworked to offer 5.8 on macOS Sequoia, and 5.7.6 for other macOS versions. Perhaps @samford can provide some insight on the best way to handle this. We should not remove the plist check simply because it is not working for this limited release.

Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the plist file aligns with what the app checks but it's not clear why they haven't added 5.8. The first-party download page for old releases and release notes for v5 both reference 5.8 but explain that it's only for Sequoia.

How we approach this depends on if upstream is going to continue creating 5.7.x versions for macOS versions lower than Sequoia or if 5.7.6 is the last pre-Sequoia release and new versions will all be 5.8+. Looking at the release notes for v4, they didn't release any 4.5.x versions after 4.6 introduced a Catalina requirement. The language is a bit different for 5.8 but it may be reasonable to assume that 5.7.6 is the last pre-Sequoia version and they will simply continue on from 5.8.

With that in mind, we can use a similar approach as little-snitch@4, where we use a skip livecheck block in the older macOS block. The tricky part here is that the plist file doesn't list 5.8 yet (only 5.7.6 and an old nightly). It may just be that they haven't updated the file yet but we can check the download page for older releases for the time being.

I'll push a commit in a moment to handle the version setup for older macOS versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants