Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/swift 3 #379

Merged
merged 26 commits into from
Apr 19, 2017
Merged

Feature/swift 3 #379

merged 26 commits into from
Apr 19, 2017

Conversation

virmaninupur5
Copy link

No description provided.

Copy link

@agates4 agates4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@muescha muescha mentioned this pull request Mar 29, 2017
Erik Strottmann and others added 8 commits April 11, 2017 20:34
- Remove `@discardableResult` from function returning `Void`
- Cast `Error?` to `NSError?` with `as NSError?`, not `as? NSError`
- Properly override `fetch` in test `Fetcher` subclasses
- Remove reliance on private `Error` properties `_domain` and `_code`
- Remove unneccessary calls to `dump`
- Uncomment `Haneke.playground` and fix compiler errors
- Update .travis.yml to Xcode 8.3
Fix test failures and Xcode 8.3 compiler warnings
URL.absoluteString isn't optional
Fix intermittent build failures on Travis-CI
@dcharbonnier dcharbonnier mentioned this pull request Apr 19, 2017
26 tasks
@dcharbonnier
Copy link
Contributor

thx to everybody, you made it !

@dcharbonnier dcharbonnier merged commit 74f34c1 into master Apr 19, 2017
@u2606
Copy link
Contributor

u2606 commented Apr 19, 2017

Can we make a new CocoaPods release?

Steps to release:

  1. Update s.version to 0.11.0 in HanekeSwift.podspec and validate by running pod lib lint
  2. Create a tag 0.11.0 on GitHub
  3. Publish to CocoaPods by running pod trunk push HanekeSwift.podspec

Anyone can complete step 1, and any GitHub maintainer (like @dcharbonnier) can complete step 2. However, it looks like @hpique is the only user CocoaPods currently considers a maintainer, so only he can complete step 3. (Alternatively, @hpique can add another contributor who can then complete step 3.)

@u2606 u2606 mentioned this pull request Apr 21, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants