-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swift 3 #379
Feature/swift 3 #379
Conversation
Convert to Swift 3 with minor changes of internal methods to conform to Swift 3 syntax
Silent unused result of call warning
fix swift3 and many test
Updated travis configuration for Swift 3
Made formats public in cache like on the master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
- Remove `@discardableResult` from function returning `Void` - Cast `Error?` to `NSError?` with `as NSError?`, not `as? NSError` - Properly override `fetch` in test `Fetcher` subclasses - Remove reliance on private `Error` properties `_domain` and `_code` - Remove unneccessary calls to `dump` - Uncomment `Haneke.playground` and fix compiler errors - Update .travis.yml to Xcode 8.3
Fix test failures and Xcode 8.3 compiler warnings
URL.absoluteString isn't optional
Fix intermittent build failures on Travis-CI
Fix intermitent CI failure by sleeping after test
Experiment with CI configuration
thx to everybody, you made it ! |
Can we make a new CocoaPods release? Steps to release:
Anyone can complete step 1, and any GitHub maintainer (like @dcharbonnier) can complete step 2. However, it looks like @hpique is the only user CocoaPods currently considers a maintainer, so only he can complete step 3. (Alternatively, @hpique can add another contributor who can then complete step 3.) |
No description provided.