This repository has been archived by the owner on Mar 6, 2022. It is now read-only.
Migrate to GSAP 3 #21
Merged
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial localized
Request by index.html `<link href="https://fonts.loli.net/css?family=Quicksand:400" rel="stylesheet">`
Request by index.html ``` <script charset="utf-8" src="https://cdnjs.loli.net/ajax/libs/jquery/2.2.4/jquery.min.js" type="text/javascript"></script> <script charset="utf-8" src="https://cdnjs.loli.net/ajax/libs/pixi.js/3.0.11/pixi.min.js" type="text/javascript"></script> <script charset="utf-8" src="https://cdnjs.loli.net/ajax/libs/gsap/1.19.1/TweenMax.min.js" type="text/javascript"></script> ```
PixiJS 6.0.2 …from PixiJS 5.3.4 TweenMax 2.1.3 …from TweenMax 1.19.1 Attention: TweenMax has been deprecated in GSAP 3 in favor of the streamlined gsap object. The last version is 2.1.3. Further update & migration to GSAP 3 is needed.
jQuery 3.6.0 from jQuery 2.2.4
Update dependence
PIXI.AbstractRenderer.autoResize property is deprecated, use PIXI.AbstractRenderer.autoDensityDeprecated since v5.0.0
Not necessary resources, only for debug. jquery 3.6.0 & pixi.js 6.0.2
minify
Replaced by new version.
Localized
In this file, the TweenLite library is called 44 times, and there are 3 functions respectively, namely TweenLite.fromTo, TweenLite.delayedCall, and TweenLite.to. According to GSAP 3 Migration Guide and GASP 3 Documentation, TweenLite can be replaced with gasp, and the function syntax remains unchanged. After verification, the TweenMax library is not called in other files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TweenMax has been deprecated in GSAP 3 in favor of the streamlined gsap object. The last version of TweenMax is released on 19 May 2019. Thus migrate to GSAP 3 is needed for potential vulnerabilities and bug fixes.
In this project, the TweenLite library is called 44 times, and there are 3 functions respectively, namely
TweenLite.fromTo(),TweenLite.delayedCall(), andTweenLite.to().According to GSAP 3 Migration Guide and GASP 3 Documentation,
TweenLite.can be replaced withgsap.for above 3 functions, and the function syntax remains unchanged.After migrate, the mikutap.js is smaller 0.21kb(-0.8%), the tweenmax.min.js (replaced by gasp.min.js) is smaller 52.42kb(-46.2%).
Commits before 1656919 have already been contained in #17.