Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change StepsRunner to be more of a builder to prepare for assigning Allocations. #1312

Merged
merged 4 commits into from
Dec 6, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Dec 6, 2018

Part of #1297

This defers running the steps till the end and allows for StepsRunner to know how many steps there are before running them all.

@coollog coollog requested a review from a team December 6, 2018 16:41
@coollog coollog requested a review from a team December 6, 2018 17:03
@coollog coollog requested a review from a team December 6, 2018 22:26
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, in this case, I think it's easier to understand when passing StepsRunner instead of a (basically) Callable (I mean ImageBuildRunnable). Using Callable makes sense if you need to invoke some logic later, but knowing that by design having a StepsRunner instance does not kick off running its steps, it is sort of like StepsRunner embeds a Callable in itself, so I think it's OK to have a separate "run" method in StepsRunner (like the previous runStepsRunners()). I think this will almost feel like StepsRunner is implementing Callable. Then BuildSteps could just call the "run" method.

@coollog coollog merged commit 887da31 into master Dec 6, 2018
@coollog coollog deleted the progress-5-StepsRunner branch December 6, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants