Change exposed port/volumes API to use sets instead of lists #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadCordle
requested review from
briandealwis,
loosebazooka,
coollog and
chanseokoh
chanseokoh
reviewed
Nov 28, 2018
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java
Outdated
Show resolved
Hide resolved
Hmm... it can be convenient, but I personally prefer accepting a But I don't feel strongly about ether way. |
|
Good point, it's definitely more predictable when it takes a Set instead of a Collection. I'll change it back. |
coollog
reviewed
Nov 28, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessorTest.java
Show resolved
Hide resolved
chanseokoh
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original comment suggesting this change.
Changes API from using lists to using sets for exposed ports and volumes, since these should not contain duplicate values.