Add Healthcheck to ContainerConfigurationTemplate #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadCordle
requested review from
briandealwis,
loosebazooka,
coollog and
chanseokoh
|
I think we could get this in even if we decide to not support it in the plugins since it still gives the Jib Core users control over this portion of the Docker container config. |
briandealwis
reviewed
Nov 5, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/WriteTarFileStep.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java
Outdated
Show resolved
Hide resolved
coollog
reviewed
Nov 6, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java
Outdated
Show resolved
Hide resolved
coollog
reviewed
Nov 9, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java
Outdated
Show resolved
Hide resolved
coollog
reviewed
Nov 19, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ImageToJsonTranslator.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ImageToJsonTranslator.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ImageToJsonTranslator.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/google/cloud/tools/jib/image/json/ContainerConfigurationTemplate.java
Show resolved
Hide resolved
coollog
reviewed
Nov 20, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/DockerHealthCheck.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/DockerHealthCheck.java
Outdated
Show resolved
Hide resolved
|
I'm actually realizing now that this API design is probably not the best if we aren't exposing this to library users; if all we're doing is propagating from base image, using different builders instead of just a setter to propagate the command is going to be a pain. So I'm going to pause on this until we figure that out. |
|
Actually, we can probably move forward with this so we can implement the base image propagation, and simplify later if necessary when we have a final decision on jib-core support. |
coollog
reviewed
Nov 28, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/DockerHealthCheck.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/DockerHealthCheck.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/google/cloud/tools/jib/image/json/ContainerConfigurationTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ImageToJsonTranslator.java
Outdated
Show resolved
Hide resolved
coollog
reviewed
Nov 30, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ImageToJsonTranslator.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ImageToJsonTranslator.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Nov 30, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/DockerHealthCheck.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/google/cloud/tools/jib/image/json/ContainerConfigurationTemplate.java
Show resolved
Hide resolved
...core/src/main/java/com/google/cloud/tools/jib/image/json/ContainerConfigurationTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/JsonToImageTranslator.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/DockerHealthCheck.java
Outdated
Show resolved
Hide resolved
chanseokoh
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any behavior yet, just prepares for #676.
Adds
Healthcheckfields to the container configuration json template +Imageclass. This field is left empty for OCI images since OCI does not support healthcheck currently.