Fix unmarshallable keys #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshalling/unmarshalling does not work when definitions cannot be marshalled (Lambda, for example).
Goltergaul
requested changes
Aug 22, 2024
Changelog.md
Outdated
| @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ## [1.1.2] - 2024-08-22 | |||
| ### Fixed | |||
| - Fixed `Keys` containing non-marshallable definitions | |||
There was a problem hiding this comment.
Suggested change
| - Fixed `Keys` containing non-marshallable definitions | |
| - Fixed "TypeError: no _dump_data is defined for class Proc" error that ocurred when a definition model inherits from another model that uses lambda based definitions |
| @@ -5,7 +5,7 @@ | |||
| describe Definition::Model do | |||
| let(:test_model_class) do | |||
| Class.new(described_class) do | |||
| required :name, Definition.Type(String) | |||
| required :name, Definition.NonEmptyString | |||
There was a problem hiding this comment.
Suggested change
| required :name, Definition.NonEmptyString | |
| required :name, Definition.Lambda { |value| conform_with(value.trim) } |
to have a test case that would cause the error that this pr fixes
jan4843
force-pushed
the
fix-unmarshallable-keys
branch
from
1cc8fa5
to
5badb46
Compare
Goltergaul
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.