Set max_length=255 for doc_file and doc_url in document model

[capooti]

Set max_length=255 for doc_file and doc_url in document model as per #2285

[simod]

@capooti wouldn't this break existing databases?

[capooti]

I don't think so, as it is just setting the field length to an higher value for new synced database.
Though best practice here it would be to have a migration script, so we may postpone this to 2.5.

[simod]

I'm afraid that the db would complain if we allow more that 100 but the it has a constraint of 100. Unless we will provide a migrations script.

[capooti]

apparently this is already happening according to #2285. We need to make
sure that the form does not accept file names longer than 100 chars then.

On Tue, Sep 29, 2015 at 9:39 AM, Simone Dalmasso notifications@github.com
wrote:

I'm afraid that the db would complain if we allow more that 100 but the it
has a constraint of 100. Unless we will provide a migrations script.

—
Reply to this email directly or view it on GitHub
#2288 (comment).

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti

[jj0hns0n]

@capooti should we go ahead and merge this one now?

[capooti]

Yes, given that now we can do schema changes.
Should we start using Django migrations for schema changes, by the way? (this way will be easier to update production systems)

[simod]

@capooti +1 for the migrations, not sure that django 1.6 has migrations yet but we should also upgrade it to the latest.

[capooti]

Yes, now I think south is integrated in django.
let's do this: when we will updated django to the latest (time to do it, imho, let me know if I may help), I will add the migration to this PR, and then we merge it

[jj0hns0n]

@capooti Can we go ahead and merge this now?

[capooti]

Sure! Go ahead