chore: filter out TX props on estimatePredicates query
#1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate and
nedsalk
as code owners
nedsalk
approved these changes
Feb 5, 2024
danielbate
approved these changes
Feb 5, 2024
arboleya
reviewed
Feb 5, 2024
arboleya
approved these changes
Feb 5, 2024
|
Coverage Report:
Changed Files:
|
arboleya
deleted the
st/chore/filter-out-tx-props-on-estimate-predicates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters out most of the queried properties for the
estimatePredicatesquery.Since we just need
predicateGasUsedfrom each predicate input, there is no reason to query all TX properties.